Christoph Deil
Christoph Deil
@leejjoon - What do you think about this new option to give a `wcs`? @gbrammer - Is this compatible / equivalent to what DS9 does? Can you add a test...
Current test coverage is at 63%: https://coveralls.io/github/astropy/pyregion Especially `pyregion/mpl_helper.py` is at 0%, if someone could add even one test that does MPL plotting, that would be very valuable to have....
@astropy/pyregion-maintainers - We need more high-level tests for `pyregion` to increase code coverage. Recently @keflavich has found two serious bugs (#109, #110) that would have been caught by any test...
I started working on this (doesn't run yet and I hadn't seen your comments that it should take a `Header` as input): https://github.com/cdeil/python-reprojection/commit/5aeb598479410414a267489277b9eb8f0abfa679 https://github.com/cdeil/python-reprojection/commit/a23d1d3a5059796534dc4914721e8e61802d4b23 What do you think about the...
Yes, a 2D loop in C is what I had in mind, probably in combination with an inlined function to compute the solid angle that takes the four pixel corner...
Processing arrays in chunks is a common issue ... I wonder if [view-as-blocks](http://scikit-image.org/docs/dev/api/skimage.util.html#view-as-blocks) would work efficiently here or if not we could figure out a utility that can be reused...
All the time is spent in `pyparsing`. `RegionParser.parseLine` calls `self.parser.parseString(l)` where `self.parser` is a `pyparsing` object created in `RegionParser.__init__` (see [here](https://github.com/astropy/pyregion/blob/master/pyregion/ds9_region_parser.py#L102)). I have no idea how to optimise that ......
This speed issue in the DS9 parser in pyregion is still of interest. Next week @joleroi will give a presentation on `regions` (but also mentioning `pyregion`) at PyAstro17 and has...
One more thing I forgot to mention: the nice thing about https://github.com/erikrose/parsimonious is that (from the looks of it, I haven't tried) one just writes down the grammar of the...
> how to write a grammar for ds9, What about the pyparsing based parser in pyregion? Is there a problem apart from the speed issue? Can you point out a...