Christoph Deil

Results 472 comments of Christoph Deil

@fxpineau - Thanks! But these parts of the code aren't isolated, they use your other classes and methods. Can you comment on these questions: - How much C or Cython...

> Maybe 100-200 lines That's not so bad. Then I think we should try to extract from your code and avoid any extra dependency in `astropy-regions` for not. Especially not...

@fxpineau @mbtaylor - Thanks! Concerning performance, I think having many points to test, in the form of Numpy arrays, is the common and important case. E.g. when you have an...

I would suggest to do the same as [spherical_geometry.SphericalPolygon](http://spacetelescope.github.io/spherical_geometry/_modules/spherical_geometry/polygon.html#SphericalPolygon), i.e. to give the caller the power to define a point that's `inside` which gives max flexibility, and to have their...

@gpdf - Thanks for bringing this up. We have [RectangleSkyRegion](https://astropy-regions.readthedocs.io/en/latest/api/regions.RectangleSkyRegion.html) already which corresponds to the [box region type in DS9](http://ds9.si.edu/doc/ref/region.html), but it's not a "pure spherical" region that can be...

I think the problem isn't actually about who types up the code. We'd love to have you as contributor of course, but I'm also willing to do that in the...

Does anyone here have time to make a pull request adding this example to the docs?

@mhardcastle documented this in #81 . > But it might be even better if this were the default behaviour in pyregion, since ds9 regions are always spatial, and so always...

Reading through this issue and #87 and stuff linked to from there, I'm confused. Can someone involved here please comment on status in `pyregion` master and is possible also whether...

@leejjoon - Can you also update the docs if needed in #113 to clear this issue out for the upcoming 2.0 release?