Christoph Deil

Results 472 comments of Christoph Deil

I didn't know that pyregion is not a complete DS9 region parser and I think wasn't part of the DS9 grammar / parse discussions last year (or forgot). OK, fine...

@keflavich - OK. I made a separate issue suggesting the docs improvements here: https://github.com/astropy/regions/issues/124

Does anyone have time for this? Maybe @bsipocz ? Having the examples datafiles at http://pyregion.readthedocs.io/en/latest/getting_started.html available in such a way that they can be executed directly without having to go...

@grahambell - Thanks for the bug report. I see the same output with Python 3.5, Astropy 1.2, Numpy 1.11.2, Cython 0.24.1. @grahambell - By any chance, do you already have...

I've started debugging this ... here's some notes. Script to print the RA / DEC values where the pyregion result is incorrect: https://gist.github.com/cdeil/ee69188cb8df95a4b8e2fca22dceea5c First incorrect result is for: ``` RA,...

Changing milestone for this issue to 1.2.

I've narrowed this down to a bug (I think) in `RegionParser.sky_to_image`. Here's a small self-contained test case: ``` python from astropy.wcs import WCS wcs = WCS(naxis=2) wcs.wcs.radesys = 'ICRS' wcs.wcs.ctype...

Here's the full list of pixels (RA, DEC) in the first two columns where `pyregion` currently gives incorrect results for the original test script (takes ~ 20 minutes to run,...

Maybe @nden or @astrofrog or someone that knows `astropy.wcs` well can comment: In the example given by @leejjoon in the comment above this one, is the `nan` output expected /...

Is this a blocker for a pyregion 2.0 release or can it be moved to 2.1? @astrofrog or @keflavich - Could you please have a look at the example by...