Christoph Deil
Christoph Deil
@astrofrog - What would be the purpose / use cases of a registry of regions? If there's a use cases for it, then yes, it does sound like a nice...
I'm 👍 on having a registry of regions. Probably we should also introduce a "region type" class-level attribute for each region, no? Looks like `shapely` does this via the `geom_type`:...
Moving to 0.3 milestone.
@astrofrog @larrybradley or anyone - Is there a standard pattern or even utilities to implement registries in Astropy core? (in a way that's simultaneously Python 2 and 3 compatible). Just...
I don't think this is a blocker for the 0.3 release we wanted to make later this week. Moved to 0.4 milestone. If someone has time to implement this, it...
@adonath - I don't think so. To me it still looks like the circle is simply drawn incorrectly. Yes, one could create SkyCoords from PixCoords, but that won't change the...
@joleroi - Thanks for pointing out that `SkyCircleRegion.as_patch` has `transform=ax.get_transform('icrs')` hard-coded. That means it's completely broken and could be fixed by changing to `ax.get_transform('world')`? @astrofrog - In #77 you still...
> The hard-coded ICRS is not a problem btw because I always convert the SkyCoord to ICRS first too. I think it is!? It leads to incorrectly distorted circles because...
I've started a new PR in #85 and will try to finish it quickly tomorrow (not much time this week). I'll try to review all the discussion and make docs...
I just now merged #85, which fixes this issue. There's a lot of good discussion and examples here, that should result in further code or docs improvements. So for that...