Jason Carver

Results 45 issues of Jason Carver

Maybe call `end_previous_txn()` or `mark_new_transaction()`. The point is that we need some explicit way to reset some things that need to be reset in between transactions. Currently, that means making...

### What is wrong? It gets passed around a lot, and my intuition is that it's not necessary (or, won't be, after #1930 is merged). ### How can it be...

### What is wrong? There were no tests in ethereum/tests covering the bugs resolved by #1913 . See the PR history, there are actually a couple variants that aren't tested,...

### What is wrong? Right now, `DBDiff` drops any `KeyErrors` that are raised when it tries to delete values in the underlying database. This is mildly annoying because `MissingTrieNode` extends...

### What is wrong? Looks related to #1111 Right now, a number of VMs are hard-coded into explicit opcode tests. This means that newer VMs were not being tested. ###...

Extract `ExecutionContext` out as something that's adjacent to `State` instead of embedded in it. When you want to execute, you run it through the `VM` which combines state with the...

* py-evm Version: master @ 942765d ### What is wrong? I *think* this is what's happening. I'm debugging a different part of the stack, so can't dive in this moment:...

### What is wrong? eg~ ``` DEBUG2 03-29 10:00:50 logging.py Setting decoded storage in account 0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa & slot 1 to value 2 DEBUG2 03-29 10:00:50 logging.py Setting decoded storage in...

For some reason, this fails the tests with: >TypeError: compute_difficulty() got multiple values for argument 'bomb_delay' ([CI job](https://circleci.com/gh/ethereum/py-evm/126329?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)) _Originally posted by @cburgdorf in https://github.com/_render_node/MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1ODgxNzM1Nw==/comments/review_comment_

### What is wrong? Python 3.6 was released nearly 2 years ago. `trinity` is alpha software, which won't be stable for another good while. Python 3.5 doesn't support some sweet...