ethereum
Contribute some account storage reset tests to ethereum/tests
What is wrong?
There were no tests in ethereum/tests covering the bugs resolved by #1913 .
See the PR history, there are actually a couple variants that aren't tested, including when a storage root is set back to the storage root from the beginning of the block.
How can it be fixed
What I'd really like is to have an API that allows us to quickly write the tests (and spit them out in ethereum/tests format). It seems like a pain to write them manually. Maybe this is a good opportunity to dogfood a first stab at such an API.
If I recall correctly, tests can be generated more easily with any client that integrates with retesteth.
On Sat, Feb 1, 2020, 07:59 Jason Carver [email protected] wrote:
- py-evm Version: x.x.x
- OS: osx/linux/win
- Python Version (python --version):
- Environment (output of pip freeze):
What is wrong?
There were no central tests covering the bugs resolved by #1913 https://github.com/ethereum/py-evm/pull/1913 .
See the PR history, there are actually a couple variants that aren't tested, including when a storage root is set back to the storage root from the beginning of the block. How can it be fixed
What I'd really like is to have an API that allows us to quickly write the tests (and spit them out in ethereum/tests format). It seems like a pain to write them manually. Maybe this is a good opportunity to dogfood a first stab at such an API.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ethereum/py-evm/issues/1914?email_source=notifications&email_token=AAD7HFLVNGFBNUSYTBGYYDDRATCQVA5CNFSM4KOPXOC2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IKJIYRA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD7HFOLSFRBISG7ICZRTUTRATCQVANCNFSM4KOPXOCQ .
