py-evm icon indicating copy to clipboard operation
py-evm copied to clipboard

Investigate why explicit bomb_delay keyword arg causes failures

Open carver opened this issue 6 years ago • 1 comments

For some reason, this fails the tests with:

TypeError: compute_difficulty() got multiple values for argument 'bomb_delay' (CI job)

_Originally posted by @cburgdorf in https://github.com/render_node/MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1ODgxNzM1Nw==/comments/review_comment

carver avatar Feb 21 '19 18:02 carver

It's gonna be related to this.

https://github.com/ethereum/py-evm/blob/42360e4f9b9b6dc90b7aeb41fe6d3b743c59966b/eth/vm/forks/constantinople/headers.py#L8

compute_difficulty is a curriable method.

I don't see where the duplicate is happening but my guess is that somewhere it's being provided as a kwarg as well.

pipermerriam avatar Feb 21 '19 18:02 pipermerriam