py-evm icon indicating copy to clipboard operation
py-evm copied to clipboard

Drop python 3.5 support in eth module

Open carver opened this issue 7 years ago • 4 comments

What is wrong?

Python 3.6 was released nearly 2 years ago. trinity is alpha software, which won't be stable for another good while. Python 3.5 doesn't support some sweet syntax like f-strings, native typing annotations, etc.

How can it be fixed

Let's drop py3.5 support from the eth module, and require >=3.6.

Objections?

carver avatar Oct 12 '18 22:10 carver

I believe we are held up by: Web3.py -> eth-tester -> py-evm eth module

pipermerriam avatar Oct 12 '18 22:10 pipermerriam

https://github.com/ethereum/py-evm/pull/1390#discussion_r224931867

Good point about web3.

Potentially web3 v4 can freeze py-evm at the current version, and updates to py-evm will only be available in web3 v5. (which I expect to be py3.6+)

carver avatar Oct 12 '18 22:10 carver

Our much ignored mailing list and /r/ethereum might be good places to solicit feedback (and prepare people).

pipermerriam avatar Oct 12 '18 22:10 pipermerriam

Good stuff! This is great from a vyper perspective - as vyper also requires 3.6.

jacqueswww avatar Oct 13 '18 07:10 jacqueswww

dropped in #1785

pacrob avatar Dec 20 '23 19:12 pacrob