Carolina Nymark
Carolina Nymark
Tests are always needed. Need to figure out how to fix the error reported by PHPCS without rewriting the full if statements.
Is anyone with PHP storm able to check the current code? (And I am not able to read the report format)
The file is nearly one year old I don't think it will be valid. That is what I mean with "check the current code".
To me this sounds a bit like the PHPCS tests? Would you mind elaborating what kind of tests you had in mind and how it differs from expanding https://github.com/WPTT/WPThemeReview/?
Yes, I had it on my to do list but if you want to work on it that would be great. There is also the scenario where the user tries...
Both. There is a CDN check but it is limited to a list of well known CDN's. https://github.com/WordPress/theme-check/blob/master/checks/class-cdn-check.php#L44
**manage_options** is (correctly) used for example for admin notices, while **edit_theme_options** should be used for - Widgets - Menus - Customizer The check can't differentiate between the types of options,...
No, I mean to not fail if a text domain is never used. Block themes that has translation functions anywhere should still be checked.
Yes, a regex would be an improvement. I question whether this check should block upload at all.
I found 11 themes (including oceanwp) that were blocked by this requirement since june 17. The requirement is in place because wp_title was supposed to be deprecated many years ago,...