theme-check icon indicating copy to clipboard operation
theme-check copied to clipboard

Go through code inspection and see what can be improved

Open dingo-d opened this issue 5 years ago • 8 comments
trafficstars

Running code inspect on the plugin in the PhpStorm IDE gives interesting results that should be checked manually

Screenshot 2020-06-10 at 19 28 56

dingo-d avatar Jun 10 '20 17:06 dingo-d

Can you get an output of the report? Maybe as a CSV or similar?

pattonwebz avatar Jun 10 '20 17:06 pattonwebz

I can export HTML and XML reports.

dingo-d avatar Jun 10 '20 17:06 dingo-d

haha so 2 better formats than what I asked for. Either one works :)

pattonwebz avatar Jun 10 '20 17:06 pattonwebz

https://gist.github.com/dingo-d/eb61bbc5403d14df6ca781d0f2e42a9a

It was pretty big to add, hope nothing crashes XD

dingo-d avatar Jun 10 '20 17:06 dingo-d

Is anyone with PHP storm able to check the current code? (And I am not able to read the report format)

carolinan avatar Jun 01 '21 02:06 carolinan

Just download the gist files into one folder and open it in the browser, should work.

dingo-d avatar Jun 01 '21 07:06 dingo-d

The file is nearly one year old I don't think it will be valid. That is what I mean with "check the current code".

carolinan avatar Jun 01 '21 15:06 carolinan

I tried running it on the newer code, but the export throws an error. I can export xml files, but not sure how to inspect those 🤷🏼‍♂️

dingo-d avatar Jun 01 '21 15:06 dingo-d