Carolina Nymark

Results 541 comments of Carolina Nymark

> Any idea how to fix the readme issues with spacing? I'll see if I can make it remove blank lines from the header, but the warning is also correct,...

https://github.com/WordPress/theme-check/pull/376/commits/8e696d2479a9e4ff7ddf01467bd5a9ba6847973c Checks if the name in the readme matches the theme name, if not, error. Updates the $latest_wordpres_version variable. Removes empty lines to prevent errors with the check. To avoid...

Does the license and license URI have a single space after the colon?

I think I found the bug where it does not show that the license is missing, but I need your full readme file to confirm. It is not only checking...

The 5.8 milestone is already open on core trac

I have not looked at this closer. Validate submitted patterns: https://github.com/WordPress/pattern-directory/issues/22 https://github.com/WordPress/pattern-directory/pull/38

https://github.com/WordPress/gutenberg/blob/trunk/packages/blocks/src/api/validation/index.js

If the block theme specific testing will be in theme review action I see no reason **-other than easy of use -** why FSE checks should also be in Theme...

> I think in 5.8 where the FSE MVP will land, we'll also need to make a few adjustments to core... > The `index.php` file in FSE themes should not...

Doesn't the uploader also require sidebar.php? All 3 would need to require the same files, uploader, theme check, theme sniffer (And not show errors for child themes).