Carolina Nymark
Carolina Nymark
There is a branch for this issue-136-non-presentational-meta but it needs testing. Should this not be combined with other restricted functions?
If this is kept as a warning, it shouldn't be used for the external fonts.
Is this only regarding adding menu pages, or other usages too?
@kkoppenhaver Maybe you can work with and improve branch 125 :). https://github.com/WPTRT/WordPress-Coding-Standards/blob/feature/issue-125-google-search-and-ad-codes/WordPress/Sniffs/Theme/NoAdvertisingOrTrackingSniff.php
None except google fonts. The requirement says: Include all scripts and resources. https://make.wordpress.org/themes/handbook/review/required/#stylesheets-and-scripts Like Kevin says this should be an error not a warning. And we should avoid using the...
This gist contains: [Things we don't allow + some CSS, HTML and JS question marks](https://gist.github.com/carolinan/8cf317a56ba9d8a4f1aae910ff4abed6) TLDR: https://stackpath.bootstrapcdn.com https://maxcdn.bootstrapcdn.com/ https://cdnjs.cloudflare.com/ajax/libs/ https://use.fontawesome.com/ https://ajax.googleapis.com/ajax/libs/jquery/ //code.jquery.com/ui/ and one new addition: db.onlinewebfonts.com/
use.typekit.net also needs to be blacklisted since we do not allow it and because of licensing.
And here is the gist with things that we do allow. https://gist.github.com/carolinan/7c2b002465b260ab3a74ec2d9b924c8c
See branch issue-127-removing-customizer-active-theme It does not cover display: none
On the other hand I have only seen this happen once. It might not be worth the effort.