Caolan McMahon

Fix transform request handling from TDS

4

These are the changes I had to make to get the XML of incoming requests properly parsed and handled. Hopefully it at least points out the issues that need addressing...

Documentation out of date on Plume and V3 transforms

6

The documentation on using Plume recommends copying "the plume.wsgi and plume.py files from the canari/src/canari/resources/tds directory to your WSGI container’s path", but plume.wsgi doesn't exist in the repository. I found...

Failing to parse Maltego transform request message

2

I'm trying to run `canari run-server` to access a transform, it appears to expose the transforms through the HTTP server but when a request comes in from the TDS it...

canari create-package produces entities.py with broken namespace

1

After doing `canari create-package example` the file `src/example/transforms/common/entities.py` contains a class called ExampleEntity which has the `namespace` property set - this value does not take effect in any sub-classes, renaming...

Terminology: pages vs. components

3

Magery is designed around custom HTML5 template tags that called 'components' (though sometimes confusingly referred to as templates in our docs). On the server-side these need to be placed into...

Error handling and reporting

1

My philosophy so far has been to avoid runtime errors based on the shape of the context data wherever possible. Otherwise, it's very easy to take out large portions of...

Should components define their 'arguments'?

5

I like to think of components as functions accepting named arguments (e.g. `title="{{ article.title }}"`). Should the `` tag also require/allow you to define the context it expects to receive?

See discussion here: https://github.com/caolan/magery-tests/pull/17/files/5285918711f76cde4fb530f82112675244ea40be#diff-f18566d3ca27221f5493800ddc402b23

Make 'components' an explicit argument to render function

1

Currently components reference each other via `this`, but that can be confusing (particularly when not explicitly calling a constructor in an OO style). See https://github.com/caolan/magery/issues/9#issuecomment-357526945 for an example of how...