canari icon indicating copy to clipboard operation
canari copied to clipboard

Fix transform request handling from TDS

Open caolan opened this issue 11 years ago • 4 comments

These are the changes I had to make to get the XML of incoming requests properly parsed and handled. Hopefully it at least points out the issues that need addressing when looking into the XML ordering bug you mentioned.

caolan avatar Mar 10 '15 11:03 caolan

@allfro did you have any plans to merge this or are you working on some alternative fix?

caolan avatar Mar 19 '15 11:03 caolan

Hi @caolan

Analyzing your merge request. I think there are a few problems though. In particular with your request to change config.py. That would break all local transforms. Also, I'm not sure how your first edit would work any different than the one-liner MaltegoMessage(blah).render(). Let me take a look at it today and see if we can fix it another way. As I said before though. run_server is deprecated and you should be using Plume instead.

allfro avatar Mar 19 '15 17:03 allfro

Thanks @allfro, I appreciate the update. I'm also not sure why the one-line variant for the first edit didn't work, I think the message property didn't get properly set for some reason.

caolan avatar Mar 19 '15 17:03 caolan

No problem,

Just take a look at Plume. It's a lot more performant than run-server. It's closer to being commercial grade. Requires twistd which I think is already installed using the setup script.

allfro avatar Mar 19 '15 17:03 allfro