Caolan McMahon

Results 62 comments of Caolan McMahon

@allfro did you have any plans to merge this or are you working on some alternative fix?

Thanks @allfro, I appreciate the update. I'm also not sure why the one-line variant for the first edit didn't work, I think the message property didn't get properly set for...

@allfro thanks for the pointers. That section in the docs talks about converting to the V2 specification, don't know if that's intentional. I've already added 'config' as the third argument...

I'm still not sure what V3 means... I've got rid of any config imports and using the third parameter as you suggested.

I'm working in a fork here: https://github.com/caolan/canari - looks like I'm getting requests through now but I'll continue working with it before sending a pull request

I ran into this problem myself today. To anyone else arriving here looking for a solution, I have been able to use the [flatten workaround](https://docs.rs/serde_qs/0.6.1/serde_qs/#flatten-workaround) described in the serde_qs docs...

Using a comment to annotate components like Python docstrings is an interesting idea, hadn't thought of that. I was assuming we'd use some attribute on the `` tag, something like:...

Comments would be more flexible. However, we wouldn't be able to provide type warnings at template compile time anyway (as we won't know the type of the data until runtime)....

I think having two separate loading mechanisms might not be necessary. Instead of doing: ```python magery.load_components("./templates/components") magery.load_pages("./templates/pages") ``` It could just be: ```python magery.load_files("./templates") ``` Which would populate both `pages`...

In which case `pages` should just be referred to as `files` so it's clear you're simply rendering the whole file: ```python magery.render_component("my-component", data) magery.render_file("path/to/file.html", data) ```