Nazım Can Altınova

Results 83 comments of Nazım Can Altınova

Hey @rniwa, is there an update on this? (Note that this is a part of interop 2025.)

This commit in #5483 removed some marker chart code that might be useful for implementing this feature: https://github.com/firefox-devtools/profiler/pull/5483/commits/7f3158c218bd7ebfd86bc79dd8c73f2ee503dfe2

I'm removing the active tab view in #5483 but I didn't remove `frameTable.innerWindowID` yet. It's mostly because there are still a few places that use it. The first thing I...

Hm, also if we remove this field we are going to lose this section in the frame tooltips: Even though we still have the origin information from the track, and...

@julienw It should be ready for review now. Let me know what you think!

I updated the code, rebased it after the TS migration and added some tests. Let me know what you think! Here's an example file that's also included in the branch:...

cc @gsnedders, @smfr, @shaseley could you review this one? Thanks!

Actually I was looking at a profile and managed to reproduce it, and this is easier to reproduce after #5298. This is happening when the stack is filtered though a...

Great, assigned it to you! Let us know if there is anything we can help.

The `powerConsumption` values in browsertime json is coming from here: https://github.com/sitespeedio/browsertime/blob/88501b651908459fdc7f7a3490bc929f7d67bd6d/lib/firefox/geckoProfiler.js#L267 and https://github.com/sitespeedio/browsertime/blob/88501b651908459fdc7f7a3490bc929f7d67bd6d/lib/firefox/geckoProfiler.js#L44-L72 So it sums up all the power values in the whole "profile". If you look at it...