Nazım Can Altınova

Results 83 comments of Nazım Can Altınova

It seems like https://github.com/sitespeedio/browsertime/pull/2220 also fixed this issue. Specifically this commit: https://github.com/sitespeedio/browsertime/pull/2220/commits/9504fc78a13f9e8f6095f6fc6d44af752154d8ff Adding the same context here: First values in the counter samples have different meanings per platform. I'm assuming...

Unassigning this issue because we realized it's not exactly an issue for Outreachy applicants. It's a lot more involved than we expected.

Ah, I was putting some printf more to see if there are any differences. And I saw that when I accept the suggestion on Lua, this functions gets called: https://github.com/Saghen/blink.cmp/blob/f2e4f6aae833c5c2866d203666910005363779d7/lua/blink/cmp/init.lua#L268-L274...

Had some time to look into it a bit more and noticed that [`show_if_on_trigger_character`](https://github.com/Saghen/blink.cmp/blob/f2e4f6aae833c5c2866d203666910005363779d7/lua/blink/cmp/signature/trigger.lua#L100) is getting called from here: https://github.com/Saghen/blink.cmp/blob/f2e4f6aae833c5c2866d203666910005363779d7/lua/blink/cmp/completion/accept/init.lua#L114 But checked the `char_under_cursor` inside of that [function](https://github.com/Saghen/blink.cmp/blob/f2e4f6aae833c5c2866d203666910005363779d7/lua/blink/cmp/signature/trigger.lua#L105) and saw...

Yep, I can verify that it gets fixed when I wrap these lines with `vim.defer_fn`. Here's the hacky code that fixes it: ```lua ... :map(function() vim.defer_fn(function() require('blink.cmp.completion.trigger').show_if_on_trigger_character({ is_accept = true...

@codershona Assigning it to you! Let us know if you need anything.

I just checked `catppuccin-mocha` on iTerm2 and it's incorrect there too. So I guess it's the source file that's incorrect.

We have made significant improvements to this since this issue. Namely: - We changed the order of tracks to use the activity score. - Changed the default visible threads to...

Thanks for the PR! > Notably, this makes the `default_implementation` passed to `source:execute` `Task` rather than `void`, so sources would need to be updated to support this. This makes sense,...