Nazım Can Altınova comments

Results 38 comments of


                                            Nazım Can Altınova

[LIB REQUEST]: Add nix Rust crate

Sure, I wanted to contribute sooner but couldn't get a chance. I will send a PR soon.

Add negative filtering ability for marker fields

This is now ready for review. Let me know what you think!

CPU data isn't used on merged threads

We are removing the old active tab view and creating a new one. It will not have merged threads, so it doesn't apply to the active tab anymore. But this...

Split the marker regexp into multiple rexeps for generic and field specific ones

This has been landed as a part of #4981, closing.

Crash when hovering a filtered-out part in an active tab view timeline

Yeah it looks like a bug related to how we filter the active tab view related samples in activity graph. I will look at it in more detail soon.

Chrome profiles are shown with 1/1/1970 datestamp (prominently in tab title)

This is fixed by #5188.

Sanitizing the time range doesn't work in this profile

We are filtering markers to the range here: https://github.com/firefox-devtools/profiler/blob/90aaed4d7d0b1712bd8cd5f555b112a2823ec3d6/src/profile-logic/sanitize.js#L283-L288 It's possible that this function can be broken. I think it was changed a bit recently.

Some `@link` tags seem to be removed by the API documenter

I found the raw API documentation for `activeLeaf` property here: https://github.com/obsidianmd/obsidian-developer-docs/blob/5ca01f620a3ec040ec19e09d1943b27d471c60e5/config/obsidian.d.ts#L4017-L4027 It looks like some of the `@link` tags are being removed.