Cédric Villemain
Cédric Villemain
after investigation, I landed in the same code as #4515 (reindent_line is run in a loop, leading to mark_change when there was not): ``` log_rule(reindent_line:90): rule is 'indent_relative_single_line_comments' reindent_line(113): set...
apparently my WIP patch reverts parts of https://github.com/uncrustify/uncrustify/pull/1378 (pass count removal is probably incomplete here)
fixed in https://github.com/citusdata/citus/pull/7914
What happens if you create the extension before citus setup and then create extension on coordinator while the extension is not installed in workers ?
Similar to https://github.com/citusdata/citus/issues/4092 which focus on reference table.
@naisila just a message to help you find this PR when you'll get a chance to look at it...
> #5692 is also trying to fix quite a similar problem. Reviewers had objected to that PR because we want to avoid modifying ruleutils as much as possible and try...
> > #5692 is also trying to fix quite a similar problem. Reviewers had objected to that PR because we want to avoid modifying ruleutils as much as possible and...
`pg_update_query_def..()` functions are only internal functions to ruleutils, the entry point for citus is `pg_get_query_def`. And this last one is handling cases and all up to the function I patched....
> > Thanks for your investigations. The team will look at this in more detail as soon as we get a chance. > > I've tried to patch in lower...