Cédric Villemain

Results 42 comments of Cédric Villemain

> > Lead to an abnormal value in GetColumn(). > > I didn't do a test/analysis yet, but I am curious about the abnormal value returned by `GetColumn()`. What do...

it looks like it's fixed, not sure if https://github.com/citusdata/citus/pull/7912 is related but it's very closed topic.

After trying your solution, I just `sudo apt install libpolly-16-dev` instead, and it works now.

I have spotted some 6 other places with similar risk, and 1 where it's one "on purpose" to get the max value as a result. Maybe it's best to merge...

> We get the value `18446744073709551612` for the `bar` column, which is `-4` when converted to `size_t`. This PR is definitely not correct. We should instead find out why we...

> Very thorough, but I think we should consider a deprecation period and a warning. Thoughts? Yes I completely agree, though at the same time I'm facing another one with...

Confirmed, the problem really is with this part `T.attribute3 as attribute2` (apparently confuse citus).

@scooreman if you can patch/compile citus, I think this patch is ok: ``` diff --git a/src/backend/distributed/deparser/ruleutils_16.c b/src/backend/distributed/deparser/ruleutils_16.c index cc0da165b..fc76a1257 100644 --- a/src/backend/distributed/deparser/ruleutils_16.c +++ b/src/backend/distributed/deparser/ruleutils_16.c @@ -2568,9 +2568,21 @@ get_basic_select_query(Query *query,...

@scooreman nice to know it works! @onurctirtir or others , I didn't made a PR for that yet, can you reopen ?