Cédric Villemain

mmh, the title was wrong, I've updated. I believe it is not supported: https://github.com/citusdata/citus/blob/ee8f4bb7e851b210b72ceb0d2d952890de14a3e9/src/test/regress/expected/multi_multiuser_master_protocol.out#L304

> Definitely an oversight then I think. In #4812, our DDL support tracking issue, we had the following marked as complete: > > > GRANT/REVOKE on database objects other than...

In function like `EnsureEnoughDiskSpaceForShardMove()` we do not check WAL space used (or estimate future usage). Looks easy to fix here, or in a similar way in other places. Correct ?

> I like that idea. But I think we would need a new `EnsureEnoughDiskSpaceForShardSplit` function and call that for shard splits, instead of reusing the `EnsureEnoughDiskSpaceForShardMove` function for this. This...

f_p_w happens on any first modification after checkpoint, true. But the image contains the "change". Now I have a doubt about how it is handled with COPY...

I am working on this issue and I have some questions. If I'm correct, while moving shards for example, it's possible that some shards exist at the same time in...

From a user point of view, we could just wrap all those size functions calls in a `run_command_on_all_shards()`. So why not just removing all the C code and write simple...

Hello @MiroslavDanek I believe your bug requires careful investigation, and time. Having access to a test server or a gdb output will definitively help...

> the worker22 is not active (existing) worker. > postgres log: WARNING: connection to the remote node worker22:**** failed with the following error: server closed the connection unexpectedly You probably...

While inspecting, I found some places in cleanup.cpp where `remove_extra_newlines==1` but apparently nothing for `remove_extra_newlines==2`. Maybe not directly related to this bug but suspicious: * https://github.com/uncrustify/uncrustify/blob/b8ae5af658838c4248270bd6dceffc16cfd15295/src/newlines/cleanup.cpp#L1028 * https://github.com/uncrustify/uncrustify/blob/b8ae5af658838c4248270bd6dceffc16cfd15295/src/newlines/cleanup.cpp#L1228