Christopher Dilks
Christopher Dilks
How about a `Debug` build type, which just keeps `-Werror` off? ```cmake # Error on all warnings if(NOT CMAKE_BUILD_TYPE STREQUAL "Release") add_compile_options(-Wall -Wextra -pedantic) if(NOT CMAKE_BUILD_TYPE STREQUAL "Debug") add_compile_options(-Werror) endif()...
Not setting `-Werror` means all warnings will still appear, they just won't be converted to errors; that is all the above proposed _non-default_ `Debug` build type would do. At first...
> Are you sure these 20 and 35.2 are not the diameters but radii? good catch, they are likely diameters; I fixed the description above.
> We need to re-tune the optics quite a lot! Business as usual. Every time the envelope is changed the optics need to be checked and re-tuned, even if it's...
> Anyway, the working branch is `dRICH_envelope_07052023` Can you make a draft PR and link it to this issue?
Macros in `macro/` also lack copyrights
And `templates/`... but where do we draw the line...
Couple of thoughts: - Could we have `surface_properties.xml` alongside of `material_properties.xml`, for the `opticalsurface`s? At least the dRICH surface tables may grow in size soon... - If we end up...
Looks good, I linked this PR to close #166. I'll leave the code review to @wdconinc. One question: will this need any change in [EICrecon's `richgeo` service](https://github.com/eic/EICrecon/tree/main/src/services/geometry/richgeo), _i.e._, the stuff...