eic
dRICH tiled aerogel; First attempt
Briefly, what does this PR introduce?
The dRICH aerogel so far has been a disk, which is unrealistic. We are tiling the aerogel, and adding carbon fiber ribs. This has consequences in terms of detector acceptance and efficiency. This PR makes a very preliminary version to tile the aerogel as a cone segment. The right shape and dimension has not yet been finalized. This draft PR aims to work with collaborators (Luisa and Rohit), for performing further test, improving coding styles and remove the hardcoded parameters and make the nesting as much as possible user-tunable.
What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [] New feature (issue #__)
- [ ] Documentation update
- [X ] Other: Before dRICH aerogel was a single disk, now we are tiling the aerogel (with realistic shapes and dimensions) .
Please check if this PR fulfills the following:
- [X ] Tests for the changes have been added
- Some preliminary tests to remove WARN and bugs has been made. Working up to the benchmark level.
- [ ] Documentation has been added / updated
- [ X] Changes have been communicated to collaborators
- Luisa Occhiutto and Rohit Singh has been communicated and they will be working on this branch for the finalization. At this moment this is not a final version. The right aerogel tile shape and choices are yet to be finalized and acceptanceXefficiency studies are to be performed. It will remain as a draft PR for the time being. Once the right shape and dimensions are finalized, we will create a final PR.
- It is also observed that neither Luisa nor Rohit is in the dev group. They have been communicated to request for a permission.
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
No
Before the aerogel was placed like this:
Now it looks like this:
(I am also curious that why the geometry is now monochromatic)
There are a few different possibilities to tile the aerogel (considering the material loss at construction level) and to minimize aerogel material production. One can obviously go as the aerogel tiling concept in Belle-2 ARICH. We will test these different possibilities (in separate branches of ePIC, if possible) and to create a final PR for the specific branch which seems more effective in terms of acceptanceXefficiency and production feasibility. The choices has been discussed in the dRICH general meeting dedicated to mechanics: https://indico.bnl.gov/event/26331/contributions/103316/attachments/60053/103148/EPIC_dRICH_19022025.pdf
Looks good, I linked this PR to close #166.
I'll leave the code review to @wdconinc.
One question: will this need any change in EICrecon's richgeo service, i.e., the stuff that links this geometry to ACTS surfaces and IRT geometry objects? I assume it shouldn't, but it would be wise to test the IRT PID implementation (if you still use it).
Looks good, I linked this PR to close #166.
I'll leave the code review to @wdconinc.
One question: will this need any change in EICrecon's
richgeoservice, i.e., the stuff that links this geometry to ACTS surfaces and IRT geometry objects? I assume it shouldn't, but it would be wise to test the IRT PID implementation (if you still use it).
Hi @c-dilks, I tested the whole chain, and it goes through without complains. I guess because, still we have one layer of 4 cm aerogel.
I get a plot like this:
The plot seems reasonable to me. As you can see systematically for each bin for lower number of photons, the tiled aerogel histograms have higher entries and for the larger photon counts the single disk configuration has higher counts.
This is what I would intuitively assume. The carbon fibre ribs are eating some photons. But, we will definitely test the features.
I'm going to let @veprbl @Chao1009 @rahmans1 review this. I'm trying to focus on operations aspects over development at this point.
