Christopher Dilks
Christopher Dilks
> If you can reproduce the error, run `RUST_LOG=info sway-overfocus ` to figure out which it is. > I almost forgot, sway-overfocus needs to be built in debug mode to...
The z-positioning and length are difficult to change, since several other detectors depend on these parameters. I will push a commit that tries to do a bit better, but we're...
Looks good enough to me. - Are the optics the same? (besides the new gaps, of course) - Does this supersede #380 ?
LGTM. Mark ready and add to merge queue.
Looks good to me. Where should we store your code to calculate the focal points? Here or in `drich-dev`?
@cpecar I updated this branch w.r.t. `main` and resolved conflicts (hopefully correctly).
> @cpecar @c-dilks What is the status on this PR? Do we want to complete this before end of March to include in campaign? This isn't needed for the campaign;...
@chchatte92 is this still planned?
@chchatte92, We might be able to resolve this finally after https://github.com/AIDASoft/DD4hep/pull/1174 And if so, the RICH example in DD4hep examples (actually a sort of unit test) should also be updated....
Yes, that would work, though `-DCMAKE_BUILD_TYPE=Release` also solves my use case without any changes. I think we should be more strict for CI builds (error on all warnings) and less...