Bartlomiej Plotka

Results 932 comments of Bartlomiej Plotka

https://cloud-native.slack.com/archives/C01AUBA4PFE/p1738594684420579 @krajorama reported some problems when testing this PR, to be investigated > I have 7000+ metrics, only ~300 reporting issues with duplicates timestamp different value

Rebased on top of https://github.com/prometheus/prometheus/pull/15998 for additional benchmark data

Latest benchmarks: ``` benchstat v1.txt v2.txt goos: darwin goarch: arm64 pkg: github.com/prometheus/prometheus/model/textparse cpu: Apple M1 Pro │ v1.txt │ v2.txt │ │ sec/op │ sec/op vs base │ ParsePromProto-2 40.50µ...

Ok, after reusing complex types and help bytes, I think it's good for this PR. We can optimize more later on, majority of this are labels.Labels and magic suffixes which...

@krajorama is deploying this for real life data.

/prombench main --bench.version=bench/protofirst

With both having protobuf enabled: Allocs and CPU much better: ![image](https://github.com/user-attachments/assets/ec0c8865-107c-4eed-9338-87c37d353fc7) ![image](https://github.com/user-attachments/assets/e6380de5-2489-4472-b862-768185d7b2ee) Unfortunately I see max_over_time alloc 1GB heap higher, although profiles suggest otherwise. This is max though, so maybe...

Yea, ideally none of those `3rd party deps, cgo`. Undocumented API might work. There is always option for others (or us) to create a separate module for darwin statistics/collector. Here...

I mean the same intention as in any RFC like spec e.g openmetrics and remote write, to guide both serving and client implementations. Something that projects and products can reference...

👋🏽 The decision is to close this issue as not planned [given the DevSummit consensus](https://docs.google.com/document/d/1uurQCi5iVufhYHGlBZ8mJMK_freDFKPG0iYBQqJ9fvA/edit?tab=t.0#bookmark=id.2dw312b2nasd). The rationales are that we already have a comprehensive documentation around PromQL ([basics](https://prometheus.io/docs/prometheus/latest/querying/basics/), [operators](https://prometheus.io/docs/prometheus/latest/querying/operators/), [functions](https://prometheus.io/docs/prometheus/latest/querying/functions/),...