Bartlomiej Plotka

icon indicating a website link https://bwplotka.dev/

icon company Google icon location London, UK icon location Fascinated by challenging engineering problems & distributed systems. Go & OSS fan. Prometheus maintainer, Thanos co-author. CNCF TAG Observability Tech Lead.

Results 932 comments of Bartlomiej Plotka

textparse: Optimized protobuf parser with custom streaming unmarshal.

I have some ideas to optimize further (see https://pprof.me/14c6981f2f1f0ab8dce893729df1da67/?profileType=profile%253Aalloc_objects%253Acount%253Aspace%253Abytes&color_by=filename), but I will do those in the next iteration - this PR is already big.

textparse: Optimized protobuf parser with custom streaming unmarshal.

/prombench help

textparse: Optimized protobuf parser with custom streaming unmarshal.

/prombench main --bench.version=bench/protofirst

textparse: Optimized protobuf parser with custom streaming unmarshal.

/prombench cancel

textparse: Optimized protobuf parser with custom streaming unmarshal.

/prombench cancel

textparse: Optimized protobuf parser with custom streaming unmarshal.

Something got stuck (filled https://github.com/prometheus/test-infra/issues/831), retrying prombench

textparse: Optimized protobuf parser with custom streaming unmarshal.

/prombench main --bench.version=bench/protofirst

textparse: Optimized protobuf parser with custom streaming unmarshal.

eh what a mess with our [testdata](https://github.com/prometheus/prometheus/blob/8d281c3491564738aab1f6735eea4542428d999f/model/textparse/testdata/promtestdata.txt) - just noticed it does not have histograms. So my microbenchmark does not include those. I will need to create a separate benchmark...

textparse: Optimized protobuf parser with custom streaming unmarshal.

Prombench is dead at the moment https://github.com/prometheus/test-infra/issues/832

textparse: Optimized protobuf parser with custom streaming unmarshal.

/prombench cancel