Bartlomiej Plotka
Bartlomiej Plotka
I guess the memory increase was expected but for extremely large blocks with millions of symbols it can matter...
I think we could be empathetic to downstream users which are our users too. Here it might mean some optionality perhaps. From prombench looks like @bboreham your optimization was quite...
Thanks for pointing! There was already an discussion about that in https://github.com/prometheus/common/issues/58 - circular dep is unlikely to change. I believe you should be able to pin yaml.v2 to version...
I don't believe client_golang itself use YAML for any logic itself.
Thanks everyone! 💪🏽
👋🏽 Interesting topic. I am not immediately opposed, but wanted to give perspective on why generally maintaining mocks next to the backend API tend to be controversial topic: * Orgs/projects...
I think this is fair improvement, but can we break compatibility there? I don't think so ): cc @beorn7 ?
👋🏽 Moved to draft, since there are some comments to address, but otherwise it would be nice to have this! Thanks!
Thanks! Naive math on how much NewDesc is worse vs MakeLabelPairs is better, easily pays of on CPU, but it is interesting on the alloc side and this is what...
OK I spend some time to see if trying to get rid of `dto.LabelPair` pointers is beneficial. Feel free to cherry-pick the PR commits or ignore (https://github.com/prometheus/client_golang/pull/1746). In the description...