Bartlomiej Plotka

Results 932 comments of Bartlomiej Plotka

Thanks! So this makes sense on operator side, but how rule-eval should consume this? rule-eval currently only reads one config map and there's no easy way (or is there?) to...

Nice, sounds like the plan would be to do projections and split by 3 at least. Is that solving your use case? Do you have more or less equal distribution...

Also before we add some complexity, have you tried compression option? https://github.com/GoogleCloudPlatform/prometheus-engine/blob/main/doc/api.md#monitoring.googleapis.com/v1.ConfigSpec

We might want to try https://github.com/GoogleCloudPlatform/prometheus-engine/issues/1629 long term

Thanks for a quick look! > [goccy/go-yaml doesn't seem to support omitzero](https://go.dev/play/p/7Dc7hOcAOGj), either. Note: I think you mean `omitempty` not `omitzero`? [AFAIK omitempty is what we want and it's supported.](https://pkg.go.dev/github.com/goccy/go-yaml#section-readme:~:text=omitempty%20%20%20%20Only%20include%20the%20field%20if%20it%27s%20not%20set%20to%20the%20zero)....

Lol it got merged in like 20m from PR creation: https://github.com/goccy/go-yaml/pull/691

I started an effort to use it on top of your PR @bernot-dev https://github.com/GoogleCloudPlatform/prometheus-engine/pull/1555 -- https://github.com/GoogleCloudPlatform/prometheus-engine/tree/omitempty - works well. But it might more clean to do a separate PR for...

Good point about omitzero noticed by @bernot-dev https://github.com/goccy/go-yaml/pull/691/files#r2039813449

Just to update on the rationales and specifics: We do want to move to this YAML library because of the following reasons: * For more compatibility around unused fields that...