Uli Bubenheimer comments

Results 190 comments of


                                            Uli Bubenheimer

fix: improve MarkerState API

@wangela can I get a review for this PR, please? I'd really like to use these improvements. Thanks.

refactor: replace most GoogleMap() rememberUpdatedState() usages with single State object and encapsulate subcomposition functionality

@wangela can I get a review & merge for this PR, please? It is functionally equivalent to current code, but improves code organization/clarity and offers minor performance improvements due to...

refactor: replace most GoogleMap() rememberUpdatedState() usages with single State object and encapsulate subcomposition functionality

Bump

Using Marker or MarkerComposable in Clustering

@mariohide are you able to provide a complete and somewhat minimal repro? I am not a maintainer, but I think a good repro may help with seeing this fixed, as...

Using Marker or MarkerComposable in Clustering

Thanks for the repro, that should be very helpful. I took a quick look: you should set Modifier.requiredSize() on the Image, otherwise it may be zero size. However, that is...

feat: Use AndroidView overload which re-uses MapView to improve performance in lazy layouts

@philip-segerfast could you verify the `OnIndoorStateChangeListener` behavior that I mentioned earlier? I suspect it will no longer work upon reuse, because we've lost the reference to the singleton listener. I'm...

feat: Use AndroidView overload which re-uses MapView to improve performance in lazy layouts

@philip-segerfast can you split the changes regarding ComposeNode -> ReusableComposeNode, and Composition -> ReusableComposition into a separate PR, please? They can be independent of the AndroidView changes, and this PR...

feat: Use AndroidView overload which re-uses MapView to improve performance in lazy layouts

> I have tested to save the entire MapClickListeners object to MapView.tag and it works well. I haven't managed to make this work properly with only storing OnIndoorStateChangeListener. You also...

feat: Use AndroidView overload which re-uses MapView to improve performance in lazy layouts

Thanks @philip-segerfast I hope to find some time to review over the coming week

feat: Use AndroidView overload which re-uses MapView to improve performance in lazy layouts

> I don't find any issues with the OnIndoorStateChangeListener. It seems to work fine to register/unregister the listener multiple times. Thanks for checking that. I've confirmed in my own testing...