android-maps-compose icon indicating copy to clipboard operation
android-maps-compose copied to clipboard
verified publisher icon googlemaps

refactor: replace most GoogleMap() rememberUpdatedState() usages with single State object and encapsulate subcomposition functionality

Open bubenheimer opened this issue 1 year ago • 3 comments

Fixes #492

bubenheimer avatar Feb 02 '24 02:02 bubenheimer

@wangela can I get a review & merge for this PR, please? It is functionally equivalent to current code, but improves code organization/clarity and offers minor performance improvements due to fewer slots used and less work performed on Compose parameter equality testing.

This being a refactor I'd like to avoid recurring merge conflicts by merging it soon. Thanks.

bubenheimer avatar Feb 08 '24 10:02 bubenheimer

Bump

bubenheimer avatar Feb 28 '24 22:02 bubenheimer

Hi @bubenheimer , thanks for the contribution. This looks good, gets the codebase a bit closer to the API design guidelines and improves overall the health of the repository.

kikoso avatar Apr 18 '24 09:04 kikoso

Incorporated in #436 . Thanks @bubenheimer !

kikoso avatar Jul 09 '24 21:07 kikoso