Uli Bubenheimer
Uli Bubenheimer
Looks great! LGT @kikoso
Using `androidx.compose.runtime.ReusableContentHost()` or friends would likely get rid of the OOM. This will leverage the ReusableComposition support from the recent release. SubcomposeLayout can be used for this as well, but...
@dudeck To clarify, I had this in mind: `ReusableContentHost(active = showMap) { GoogleMapViewInColumn(...) }` instead of `if (showMap) { GoogleMapViewInColumn(...) }` I would not expect the OOM to go away...
LazyColumnn has ReusableComposition built in these days, so I guess an additional `ReusableContentHost` seems odd.
@dudeck not sure without experimenting or digging into impl. I assume LazyColumn would deactivate the reusable composition when an item falls off the radar. That should deactivate an item's Google...
@KrisBogaert curious why you consider this "NOT a good practice". I agree that it is a workaround, but I assumed it was a common and favorable pattern for pure Compose...
> Re-reading my comment I should have written is "not an optimal practise" according to the book because with fewer OnDestroys being handled de facto you keep your app longer...
> Is there any trick to speed it up or am I doing something wrong? I'm already on the last 6.4.0 version. Generally speaking, applying R8 & baseline profiles should...
Prior comment, for additional context: https://github.com/googlemaps/android-maps-compose/pull/436#issuecomment-1932324772
Just as an aside thought, not directly linked to this issue: the initial composition phase of the `GoogleMap()` subcomposition theoretically would not need to be performed on the main thread,...