Uli Bubenheimer

Results 190 comments of Uli Bubenheimer

I went to implement my own stream-based protocol to await server RPC initialization on the client, in the case of bidirectional streaming. This requires coupling request flow and response flow,...

I suppose I can tie up the 2 flows via the response flow's CouroutineContext, as an alternative to my current singleton-like approach. Cumbersome, but seems the cleanest approach, for a...

At least the server side of this example looks pretty straightforward to carry over to grpc-kotlin, presuming knowledge of ServerCalls, generated Kotlin service stubs, and the original Java example.

The more general parts of the server code could look as below: ``` /** * Rewrites the ServerServiceDefinition replacing one method's definition. */ private fun replaceMethod( def: ServerServiceDefinition, newDesc: MethodDescriptor,...

@bmc08gt I believe the most significant problem is your usage of rememberMarkerState(). You never actually update the MarkerState location. The rememberMarkerState() position parameter is only used for state initialization, not...

@bmc08gt in your original example, do you reuse the List object and simply clear and completely repopulate it when you send updates? If so, it may help to use a...

Compose Runtime 1.5.0 added `StateFactoryMarker` to flag these usages. However, it is only applicable to function calls, not constructor calls. android-maps-compose uses constructor calls for creating State objects. I have...

@JSpiner I agree with deprecating rememberMarkerState, it's a misleading API. The `@ReplaceWith` part seems off, though; I think it should give the original implementation of rememberMarkerState, to preserve semantics, and...

> When merging @bubenheimer 's suggestion on github, he's name was included in the commit author [5761aaf](https://github.com/googlemaps/android-maps-compose/commit/5761aafbc991ea4739a48273bc28da6d60010f7f). Would you also agree to the CLA? Done

There are a few problems with this example. In particular ~you need to~ _I would_ `rememberUpdatedState(selectedLocationIndex)`. See if that addresses the issue. Others: 'key(index)', LaunchedEffect(pagerState.currentPage). There may be a few...