Brian Smith

Results 347 comments of Brian Smith
trafficstars

> The fix was released in yari `v2.51.1` but that version hasn't been published to [npmjs.com](https://www.npmjs.com/package/@mdn/yari?activeTab=versions). I don't remember if it's a manual publish or they've put some automation for...

I think that's a good idea. We have 26 `marking.md` files in the learning-area repo: ``` ./html/multimedia-and-embedding/tasks/images/marking.md ./html/multimedia-and-embedding/tasks/media-embed/marking.md ./html/forms/tasks/form-validation/marking.md ./html/forms/tasks/other-controls/marking.md ./html/forms/tasks/styling-basics/marking.md ./html/forms/tasks/html5-controls/marking.md ./html/forms/tasks/form-structure/marking.md ./html/forms/tasks/advanced-styling/marking.md ./html/forms/tasks/basic-controls/marking.md ./html/introduction-to-html/tasks/advanced-text/marking.md ./html/introduction-to-html/tasks/links/marking.md ./html/introduction-to-html/tasks/basic-text/marking.md ./javascript/oojs/tasks/object-basics/marking.md ./javascript/oojs/tasks/oojs/marking.md...

I just noticed we have the same text in https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept-Post, so we need to update that there, also.

Just going to merge so we don't forget, thanks both!

> Thanks for the review @bsmth - I modified the part you were concerned about ([#33198 (comment)](https://github.com/mdn/content/pull/33198#discussion_r1575868493)) and I'm happy it addresses your comment, so merging. But, if you disagree,...

Thank you! > One question is whether we need to provide some versioning information here about the Vue we're targeting? I.e. Vue3/Vite? Good idea. Isn't there a note in related...

@hamishwillee - the related code has been merged (linked PR above) and I've added the notes as you suggested (in https://github.com/mdn/content/pull/33167/commits/de67367f1a148f9168e5406549661cf9f6a9d324 and https://github.com/mdn/content/pull/33167/commits/011cd2324f9ea971e9320f7eadc0f62bbd9614aa)! I'm going to merge now so both...

> In addition to the inline comments, we need to double-check if the _drawio_ files can be stored there. I hope this, but I don't remember the outcome of a...

Thanks a lot for raising this one. The page at https://developer.mozilla.org/en-US/docs/Web/CSS/CSSOM_view/Coordinate_systems recently had some improvements, do you think that's clearer in illustrating what the viewport is? I think the diagram...