content icon indicating copy to clipboard operation
content copied to clipboard

Vue upgrade

Open bsmth opened this issue 1 year ago • 2 comments
trafficstars

Description

Updating the docs for Vue in parallel while updating the todo vue app.

Motivation

The versions we were suggesting are no longer current when using Vue starter templates. The prose here is based on experience upgrading in the linked PR. The https://github.com/mdn/todo-vue app also had some security advisories, so it would be good to be using packages without known vulns.

Related issues and pull requests

  • [ ] https://github.com/mdn/todo-vue/pull/171

TODO

  • [ ] Add note about versions this tutorial targets
  • [ ] explain tree shaking / bundle splitting

bsmth avatar Apr 19 '24 09:04 bsmth

Thank you!

One question is whether we need to provide some versioning information here about the Vue we're targeting? I.e. Vue3/Vite?

Good idea. Isn't there a note in related framework guides saying this article targets XYZ, I think we can do the same here. I will add to this PR.

So you can merge if you like or wait for more expert review.

Thank you! I revisited this again after doing an initial run though in January, so I think we're in a good place, but if I can get another pair of eyes on the example repo it would be great. I've tagged Vinyl, but I'll see if I can get someone to have a look in case I've missed anything.

bsmth avatar Apr 22 '24 14:04 bsmth

@hamishwillee - the related code has been merged (linked PR above) and I've added the notes as you suggested (in https://github.com/mdn/content/pull/33167/commits/de67367f1a148f9168e5406549661cf9f6a9d324 and https://github.com/mdn/content/pull/33167/commits/011cd2324f9ea971e9320f7eadc0f62bbd9614aa)! I'm going to merge now so both repos are in sync. Thanks a lot!

bsmth avatar May 02 '24 12:05 bsmth