Brian Smith

Results 357 comments of Brian Smith
trafficstars

I think this is okay - we don't seem to be using any deprecated features, but the jest tests are failing (also on `main`).

Going to merge for now as I think this is low-risk

> [@bsmth](https://github.com/bsmth) How about if the shared-assets repo would support Mermaid and automatically render/deploy them? Yeah I think this is another good option where we have build / optimization scripts...

As far as I remember, this is under https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/cancel_event `HTMLElement` instead of specifically `HTMLInputElement`, although BCD puts it under `HTMLInputElement`: https://github.com/ntdiary/browser-compat-data/blob/main/api/HTMLInputElement.json#L201-L239

Indeed, there's a larger discussion about where this should live in https://github.com/mdn/content/pull/30946

Thanks, all. @5idereal - there are some review comments for you (and merge conflicts, unfortunately), are you coming back to this one?

Thank you very much for the help. If you need some assistance with reviews or tooling, please reach out. It would be great to minimize the amount of manual work...

Thanks for tagging me. It looks like a BCD issue, there's some notes about mobile usage here already: https://developer.mozilla.org/en-US/docs/Web/API/Window/beforeunload_event#usage_notes Was it fully unsupported before [WebKit Bug 219102](https://webkit.org/b/219102) or only in...

BCD for this originally added in: - [x] https://github.com/mdn/browser-compat-data/pull/3639

Thanks for opening this one, I think that's a good fix, there's one comment about running locally versus the preview, but I think we could even ignore my suggestion and...