Brian Smith

Results 307 comments of Brian Smith
trafficstars

> Please take a look here: > https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/lineTo#javascript > this example has beginPath, and if you delete that line, the example still works. Why should we leave beginPath there but...

Committed the linter suggestion and going to merge shortly! Thank you!

Hi @zestful - thanks for raising it. Just linking here for some notes: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/lang#accessibility_concerns Just to clarify; you mean this is bad for AT: ```html Deutsch ``` And this should...

@zestful do you have any references that show this to be true? I cannot find any information to back up the recommendation.

> * feature status > * technology status I like both of these and they're congruent with https://developer.mozilla.org/en-US/docs/MDN/Writing_guidelines/Experimental_deprecated_obsolete

Thanks, @OnkarRuikar I am done with that review round. Feel free to ignore/resolve the style comments, mostly some suggestions on `technology_status/index.md` for you to consider.

Relates to https://github.com/mdn/content/pull/22186

Thanks all, I've opened a discussion so we can come to an agreement on how to move forward here: https://github.com/mdn/mdn-community/discussions/293

Minor conflicts after https://github.com/mdn/content/pull/23602 has landed. Regarding the changes, I am +1 on at least renaming the files, i.e. the following looks fine to me: * `/glossary/descriptor_(css)/index.md` -> `/glossary/css_descriptor/index.md` Is...

> > Is it necessary to also change the slugs? > > Yes. [yari throws error](https://github.com/mdn/yari/blob/12237b761733a9abeb55421b75833ef30e2ecd5e/build/index.ts#L308) Of course, I forgot about that, thanks for clarifying.