Warner Losh
Warner Losh
I plan on merging this on Friday this week.
Taking another look... It applied cleanly for me...
I agree.. we need more people landing pull requests so we can get the feedback to them faster. I akso agree phab is the place non co mitters submit patches...
@lemul What do you think? I think this is good, but a second set of eyes would be good.
Ooops. Missed the exchange back in June. I'll land this now. In the future, the commit message should have "PR: " in it. As well as an explanation for why,...
Automated message from ghpr: Thank you for your submission. This PR has been merged to FreeBSD's branch. These changes will appear shortly on our GitHub mirror.
I'm not sure if the changes @Rin0913 pushed are all that are needed, but in any case I think another round of review is needed.
> @bsdimp > > Thank you for replying. Which part do you think is unnecessary? Or should we keep this test skipped? I think that this just needs review. Anything...
This change is too large. It has a lot of gratuitous changes that aren't strictly necessary. 49 changes and 244 files is simply too much to review. A quick survey...
OK. I've snagged the newbus parts of this that we're going to take. The cleaned I didn't pull isn't enough of a change to consider at this time and we...