Warner Losh
Warner Losh
Sorry for the tardy feedback. This looks good to me, but I'm not an expert in this area, so I've ask a few other folks to look at this. @bsdjhb
meged. Couldn't push for some reason though.
> @markjdb prefers `intr_event_destroy()` returning an error for `ie == NULL`. Problem is this is answering the **wrong** question for most callers. Since this is called from cleanup/error paths, the...
We are looking at this, but work for both mark and i have been busy. We're sorry for this taking a while, but as you know this isn't a simple...
I think we may need to snag the 'no brainer yes' bits and iterate. So I'll look at doing that.
I wonder... what do you think about making this a script in tools/build somewhere that we run. Then the repetition won't be a problem...
*DO NOT ADD PULL REQUEST: LINES TO YOUR COMMIT MESSAGES* OK. Please don't add these, as it slows me down when I'm landing the pull request. My landing software automatically...
Looking at it again, this looks good enough for now. Is there some reason for @bapt to do the review?
For me, it's just no time.