prebid-server Events: Inject tracker if events are enabled

Jul 09 '24 16:07 Pubmatic-Dhruv-Sonone

With this PR, can we finally enable? Or should we keep line 62 below?

60 // Events indicates the various types of events to be captured typically for injecting tracker URLs
61 // within the VAST XML
62 // Don't enable this feature. It is still under developmment. Please follow https://github.com/prebid/prebid-server/issues/1725 for more updates
63 type Events struct {
64     Enabled    bool        `mapstructure:"enabled" json:"enabled"`
65     DefaultURL string      `mapstructure:"default_url" json:"default_url"`
66     VASTEvents []VASTEvent `mapstructure:"vast_events" json:"vast_events,omitempty"`
67 }
config/events.go

@bsardo you edited line 64 some time ago, are we ready to enable?

I'm not sure off the top of head. @Pubmatic-Dhruv-Sonone are you expecting to open additional PRs to complete this feature?

Sep 16 '24 17:09 bsardo

@bsardo I will be creating new PR for Prometheus stats and moving existing impression tracker URL to event framework.

Sep 17 '24 05:09 Pubmatic-Dhruv-Sonone

@bsardo Addressed comments. Please check.

Oct 21 '24 06:10 Pubmatic-Dhruv-Sonone

Hi @Pubmatic-Dhruv-Sonone, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 so we can resume reviewing. Thanks!

Nov 04 '24 16:11 bsardo

@bsardo Merged the latest prebid master. Please check.

Nov 06 '24 16:11 Pubmatic-Dhruv-Sonone

@Pubmatic-Dhruv-Sonone see my latest comments.

Feb 17 '25 03:02 bsardo

@Pubmatic-Dhruv-Sonone as discussed offline, I will look into whether events_enabled is still in use to determine if this is a breaking change. I still need your input on this comment though.

Mar 24 '25 02:03 bsardo

@bsardo : If I can remember correctly, events_enabled is old flag. And we have introduced events.enabled flag. and planned to deprecate events_enabled with proper migration

Aug 10 '25 04:08 ShriprasadM