prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard
verified publisher icon prebid

Rubicon Bidder: bid.ext.prebid.meta returns as it is

Open AntoxaAntoxic opened this issue 1 year ago • 1 comments

AntoxaAntoxic avatar Oct 01 '24 09:10 AntoxaAntoxic

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 75c0b647f9863d147917f44a5389c85292daf9ac

rubicon

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:185:	resolveVideoSizeId			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:203:	appendTrackerToUrl			87.5%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:219:	Builder					100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:231:	updateRequestTo26			92.3%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:256:	MakeRequests				81.3%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:573:	createImpsToExtMap			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:592:	prepareImpsToExtMap			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:611:	splitMultiFormatImp			61.5%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:648:	resolveBidFloor				100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:656:	updateImpRpTarget			81.8%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:761:	extractDfpAdUnitCode			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:771:	isNotKeyPathError			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:775:	addStringAttribute			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:779:	addStringArrayAttribute			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:783:	updateUserRpTargetWithFpdAttributes	70.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:813:	updateExtWithIabAttribute		100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:822:	populateFirstPartyDataAttributes	92.9%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:850:	isStringArray				100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:860:	isBoolArray				100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:870:	convertToStringArray			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:881:	rawJSONToMap				100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:889:	mapFromRawJSON				80.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:898:	getSegmentIdsToCopy			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:918:	contains				75.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:927:	isVideo					100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:936:	isFullyPopulatedVideo			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:941:	resolveNativeObject			88.2%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:973:	setImpNative				82.4%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1002:	MakeBids				92.2%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1102:	mapImpIdToCpmOverride			90.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1120:	resolveAdm				87.5%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1135:	cmpOverrideFromBidRequest		100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1144:	updateBidExtWithMetaNetworkId		82.4%
total:									(statements)				84.9%

github-actions[bot] avatar Oct 01 '24 09:10 github-actions[bot]

Hi @AntoxaAntoxic, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

bsardo avatar Nov 04 '24 17:11 bsardo

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 01578997434ee958a1863ee756b5ac8057f505a8

rubicon

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:187:	resolveVideoSizeId			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:205:	appendTrackerToUrl			87.5%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:221:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:233:	updateRequestTo26			92.3%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:258:	MakeRequests				81.3%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:575:	createImpsToExtMap			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:594:	prepareImpsToExtMap			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:613:	splitMultiFormatImp			61.5%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:650:	resolveBidFloor				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:658:	updateImpRpTarget			81.8%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:763:	extractDfpAdUnitCode			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:773:	isNotKeyPathError			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:777:	addStringAttribute			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:781:	addStringArrayAttribute			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:785:	updateUserRpTargetWithFpdAttributes	70.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:815:	updateExtWithIabAttribute		100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:824:	populateFirstPartyDataAttributes	92.9%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:852:	isStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:862:	isBoolArray				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:872:	convertToStringArray			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:883:	rawJSONToMap				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:891:	mapFromRawJSON				80.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:900:	getSegmentIdsToCopy			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:920:	contains				75.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:929:	isVideo					100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:938:	isFullyPopulatedVideo			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:943:	resolveNativeObject			88.2%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:975:	setImpNative				82.4%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1004:	MakeBids				92.2%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1104:	mapImpIdToCpmOverride			90.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1122:	resolveAdm				87.5%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1137:	cmpOverrideFromBidRequest		100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1146:	updateBidExtWithMetaNetworkId		82.4%
total:									(statements)				84.9%

github-actions[bot] avatar Nov 05 '24 07:11 github-actions[bot]