Bryce Osterhaus

icon indicating a website link https://bryceosterhaus.com icon indicating an email [email protected]

icon company @liferay icon location Dubai icon location If you email me, include your favorite breakfast item in the title.

Results 71 comments of Bryce Osterhaus

wip(eslint-plugin): add new blank-line-declaration-usage rule and tests for it

@kresimir-coko yeah this is starting to look good, you can probably clean up the commits at this point. Also, can you run this over DXP and analyze the errors and...

wip(eslint-plugin): add new blank-line-declaration-usage rule and tests for it

@kresimir-coko you can ignore this rule in the senna project, you just need to add it to its eslint config. Additionally, can you add the manual changes to satisfy this...

wip(eslint-plugin): add new blank-line-declaration-usage rule and tests for it

@kresimir-coko how many instances are there of this failure? Keep in mind that we don't necessarily need to auto-fix every single error. The auto-fix is primarily helpful for the initial...

wip(eslint-plugin): add new blank-line-declaration-usage rule and tests for it

@kresimir-coko ah I see, seems like still a lot to parse through. In that case, let's just put this on hold for now and address at a later date. Might...

Standardize events to use `key` instead of `keyCode`

Using this issue for standardizing key => keyCode with an eslint rule Additionally, we might want to use a codemod for updating DXP uses.

test(js-toolkit): Update Poshi Standalone support for js-toolkit

@john-co I don't think CI commands are active on this repo, are they?

npm-scripts breaks vite file

@allen-ziegenfus is there an example in portal we can test against? Or do we need to just add that fie ourselves to test?

npm-scripts breaks vite file

Thanks! I created an LPS to track this so that it can be added to a sprint of ours, https://issues.liferay.com/browse/LPS-176124

Adding node shims for a third-party dependency

Hey @thektan! Thanks for opening this. How urgent is this need? We can fit it in at some point, but just want to get an idea of how soon we...

Adding node shims for a third-party dependency

@thektan good to know! Let us know if/when this becomes more urgent. We will keep this in our backlog and hope to address it soon, however we are working on...