Bryce Osterhaus

Results 71 comments of Bryce Osterhaus

😢 ``` +----------------------------+--------------+--------------+------------------------+ | Package | Old Size | New Size | Difference | +----------------------------+--------------+--------------+------------------------+ | @clayui/card | 175.8 KB | 206.0 KB | ⭡ 30.2 KB (17.17%) | |...

I tried adding the compiler to babel and our build but the size increase was significant. Not sure why it bloated the size of everything. It claims to optimize the...

@ethib137 yeah that is odd that those are so big. I don't know if the "stats" github action bundlers all the dependencies as well, so it's possible that "card" is...

@ethib137 so the reason the sizes are so big is because we are treating each package as an "entry point" so if an existing project brought in `@clayui/card` it will...

@ethib137 it does significantly change the sizes when excluding clayui/* I am gonna try to revamp the stats a bit and fall more in line with our [DXP size report...

testing again with compiler enabled at build to see new stats table

This is the new size with react-compiler enabled. I believe it is adding size because it is "auto-memoizing" things, so we can expect more code but it _should_ be more...

One interesting note with the compiler enabled, is that I noticed it removed "useMemo" from some of the packages I looked at the built file.

I am going to send a separate PR just for the eslint part and merge it(https://github.com/liferay/clay/pull/6111). I want to keep this up for info on the babel part and we...

Oh you know what... I think the bloat in every package is due to bundling `react-compiler-runtime`. Really, this would be served by DXP, similar to react and react-dom. I tried...