Bryce Osterhaus

Results 71 comments of Bryce Osterhaus

Personally I haven't had a ton of issues working with modal, although I also haven't used it a ton. I'm happy to switch up the API and try to make...

@matuzalemsteles whats the status on moving the DataProvider to live in DXP? I remember a few weeks back we decided it was best to move DataProvider from clay to dxp

@protoEvangelion yeah I think pushing to remote before adding the PR content would make sense.

here is a simplified example showing the issue ``` js import Component from 'metal-jsx'; class Child extends Component { created() { this.incrementCount = this.incrementCount.bind(this); this.handleClick = this.handleClick.bind(this); } handleClick() {...

Here is an example of a use case that SYNC_UPDATES is needed https://jsfiddle.net/defzoaop/1/ ```jsx class ControlledInput extends JSXComponent { handleChange(event) { this.state.inputValue = event.target.value } render() { return ; }...

@yuchi I believe its because the batch updating is not registering the intermediary state changes. So that is why when turning SYNC_UPDATES on, it will work as expected.

If you try typing very fast, the input doesn't register all of the keys. Here is a gif of me typing "asdf" over and over https://gyazo.com/f321436e6e28faf5ea2522701a041085

Looked into it a bit more and it seems okay that falsey values get registered as children. However, there is no easy way to check if the child is falsey...

this fiddle should work now https://jsfiddle.net/defzoaop/7/. Its for metal version 2.4.7.

cc @pat270, I see you were the one to add the docs for this