Bruno Renié comments

Results 47 comments of


                                            Bruno Renié

Fix iterating over headers

That's probably an API change in aiohttp. If it now provides case-insensitive header lookups there is no need to iterate anymore. I'll have a look!

Security issue with only generating link using only signed user pk

Using the password hash is fine even is the password is set to the previous one -- the password salt changes which invalidates old URLs. What we could do is...

Security issue with only generating link using only signed user pk

We need to expose `user_id` because the token would be a hash (1-way) instead of a signed value (2-way) like it is now. Verifying a token would mean 1) fetch...

Updated spanish translation

Yeah, I'll fix the docs build. Could you update the `.mo` as well? Thanks!

Is this still being maintained?

@jmbowman thanks, indeed I'm happy to transfer ownership to a maintained fork. Is the EDX fork the one you're referring to?

Is this still being maintained?

Thanks!

Is this still being maintained?

Thanks @jmbowman, interesting read :+1:

Removed admin.autodiscover() call

@fmalina Thanks! Do you know why the Travis build is failing?

Removed admin.autodiscover() call

Afaict all django versions are failing, not just old ones.

cond() missing 1 required positional argument: 'next_run'

This has been fixed in `master`: 428a6d1c7f71a64911576a772d82b7faf3c16dcc I'll make a release with the `url` fix.