Bruno Renié
Bruno Renié
Would it be possible to add a regression test? I'm not sure which conditions triggers this issue.
Sounds good, but no reversing should be needed with your wording: https://github.com/brutasse/graphite-api/blob/master/graphite_api/utils.py#L32-L38 -- I realize the example is wrong, it's the other way around. Could you submit a PR?
@JFC-MC sure, I'm happy to review/merge a PR that makes Cairo optional!
Thanks for this -- looking at the same code in graphite-web, I don't see why graphite-api's behavior would be different than graphite-web's: - https://github.com/graphite-project/graphite-web/blob/master/webapp/graphite/render/grammar.py#L57 - https://github.com/graphite-project/graphite-web/blob/master/webapp/graphite/render/grammar.py#L79-L80 These seem to match...
Nice! It looks like a minor edit is needed in `docs/api.html` as well. It still mentions `graphTemplates.conf`. Do you think you can add a test? Maybe with SVG rendering to...
I meant having a `templates` section in `default_conf` in `graphite_api/config.py`. For people needing graphite-web's vanilla templates, they wouldn't have any configuration to do because templates would already be there (you...
I'd be in favor of dropping the template-related code and document that graphite-api doesn't have templates and passing `&template=` is a no-op.
Yes, absolutely. It'd be worth passing the info to the finders.
@zeph this piece of code is from graphite-web, it was added in https://github.com/graphite-project/graphite-web/commit/f18bb3c711bd566debf3edcc6b895be9fb6210b0 I don't know what was the original intent…
Here's a summary of the attempted "fix": https://github.com/graphite-project/whisper/pull/139 I [ported it](https://github.com/brutasse/graphite-api/commit/3a0497e1f3343e329e65c897dfd8d4616b775aa5) indeed, then [reverted it](https://github.com/brutasse/graphite-api/commit/2847d5788bc8adbd8d864a234d7e4cb39210fc29) but there has been no release since the revert. I have juste pushed 1.1.3 which...