asyncio-sse icon indicating copy to clipboard operation
asyncio-sse copied to clipboard

Fix iterating over headers

Open dano opened this issue 10 years ago • 4 comments

This fixes iterating over each entry in the headers dict - you're trying to iterate over each key/value pair, but the current code just iterates over the keys.

dano avatar May 15 '15 03:05 dano

That's probably an API change in aiohttp. If it now provides case-insensitive header lookups there is no need to iterate anymore. I'll have a look!

brutasse avatar May 19 '15 07:05 brutasse

Yes, the most recent versions of aiohttp keep the headers in a case-insensitive dict, so there's no need to iterate at all. I suppose you might want to keep the iteration for backwards compatibility, though.

dano avatar May 23 '15 17:05 dano

+1 Should be merged, please!

mborho avatar Dec 24 '15 11:12 mborho

:+1:

sbidoul avatar Jul 02 '16 17:07 sbidoul