Bruno Garcia
Bruno Garcia
Force-pushed addressing https://github.com/bitcoin/bitcoin/pull/31012#discussion_r1785875497 and https://github.com/bitcoin/bitcoin/pull/31012#discussion_r1785885817. Thanks, @dergoegge.
> Copy and pasting the command from the docs doesn't work: Just fixed it. Can you check it?
> -v2transport=0 should be added to the bitcoind args used for netdriver fuzzing. Otherwise, it doesn't seem like honggfuzz ever fuzzes anything besides the v2 handshake. Well noticed, just added...
> Also playing around with this and reading the [netdriver post](https://blog.swiecki.net/2018/01/fuzzing-tcp-servers.html) (i couldn't find any other docs on it) I'm not sure if this will ever even get past the...
> If we're going to be peppering the code with these, could we add a safety harness to make sure it's never being used accidentally for a live node? Seems...
> Can you provide more details here? IIUC a hash will still be calculated, just not compared, so this may only drop one hash call, with a possible maximum speed-up...
Since everyone agrees on removing Honggfuzz netdriver, I think we can change the approach to simply just remove it from the documentation.
Closing this in favor of #31092
https://github.com/btcsuite/btcd/pull/2260 is closed to be merged, will work on it here soon. edit: merged 🎉
> Perhaps this makes more sense in combination with a test that uses it? Currently FuzzedSock::Accept seems entirely unused: https://maflcko.github.io/b-c-cov/fuzz.coverage/src/test/fuzz/util/net.cpp.gcov.html I agree. I was going to ask steps to reproduce...