Bruno Garcia
Bruno Garcia
> IMO AddrManImpl::GetAddr_() capping max_pct is reasonable. It already caps max_addresses. And then we can ensure it does by throwing any random numbers at it and making sure it does...
> Somehow I feel it is safer to treat values >100 as 100 and document that instead of crashing with an assert (or bad alloc). Sure, I will address this.
Force-pushed adding the cap of `max_pct` in `GetAddresses`, changed the PR description as well. Thanks, @vasild.
Force-pushed addressing https://github.com/bitcoin/bitcoin/pull/31235#discussion_r1832608263
Force-pushed: - Adjusted the cap and added the `Assume` for the `max_pct`. - Adjusted `GetAddr` and `GetAddress` documentation. - Adjusted both connman and addrman fuzz targets to use values from...
Force-pushed squashing and addressing https://github.com/bitcoin/bitcoin/pull/31235#discussion_r1836765925.
Worth adding a release note?
> One thing to consider is that this PR changes the REST interface from being read-only to also being able to "modify" node state (mempool in this case). This PR...
I tried with my Ledger Nano S Plus on macOS 13.0 and worked. I will try to test it on 10.15.
I tried on other versions and worked fine. Did you unlock the HW?