Brian Anderson

Results 400 comments of Brian Anderson

@danburkert "Add examples" can be checked.

The low-hanging fruit here is done, but there's so much unsafety in the runtime that there's plenty more that can potentially be done to introduce safe abstractions around the unsafe...

The state of sui move is discouraging. Their Move codebase is part of the sui tree, and the Move subdirs only slightly resemble the upstream Move code organization: https://github.com/MystenLabs/sui/tree/main/external-crates/move The...

Well, good news is that rebasing onto the `sui-move` branch of the move repo is not too hard. Here is a first try: https://github.com/brson/move/tree/solana-sui-base The tests run, but not all...

The IR test failures appear to mostly be because the compiler is emitting IR function definitions in a different order than on the main branch.

The sui compiler had a curious change that caused `move-build` to seemingly not work with bytecode dependencies. Applying this patch made those tests pass again: ``` +++ b/language/move-compiler/src/command_line/compiler.rs @@ -598,6...

> Can it be bc we are processing modules in a reverse order. I found this to be problematic for DI building and restoring the order returned by move compiler,...

Ok, this branch that is rebased onto the `move/sui-move` branch appears to pass all the tests it passed previously: https://github.com/brson/move/tree/solana-sui-base I have filed several new issues revealed during the rebase:...

Update: My previous attempt to rebase attempt failed, where I was trying to rebase onto the latest (but old) sui branch of move, then apply diffs to the sui codebase....

After further experiments I don't think stripping solves my problems from https://github.com/solana-labs/move/issues/303. Stripping does not remove symbol names from the dynamic symbol table (.dynsym), and that is where the large...