Brian Anderson
Brian Anderson
Ah that is probably the case that the language directly understands push and pop and knows when a vec is empty - the naming of the vector::destroy_empty function does imply...
Our test harnesses use the datatest_stable crate to implement tests. We do this because it is what the other move crates use for their tests. datatest_stable doesn't appear to expose...
Make sure to run cargo fmt --checked too.
We probably only need to run the move-mv-llvm-compiler tests and the move-native tests. Or at least, have one configuration doing just those, and another doing the full test suite. Note...
The license headers are enforced by CI, probably in the xlint tool, so if we make any changes we'll need to change that tool or its configuration. For the code...
Newtypes do look pretty reasonable though there are a number of impls to fill in. But also it seems a reasonable idea to me that rustdoc should duplicate the appropriate...
I've unassigned myself since I've been doing nothing on this for so long.
I peeked at the details of this task briefly and it does not look so simple; certainly not as simple as converting (in the above example) `register_histogram_vec!` to a const...
Thanks for the feedback @breeswish! I'll ask more about them when I start this work.
Per https://github.com/pingcap/rust-prometheus/issues/217 we're about ready to upgrade to 2018. From there we can add the two required features and do 1.0. Time is getting quite tight to get it out...